feat(milestones): add resilient loading and scoped recovery - #1139
Merged
mikewheeleer merged 1 commit intoAug 30, 2026
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the milestones board's loading and failure behavior so users keep their context while the board resolves or recovers.
What changed
MilestonesBoardSkeleton, shared by the App Router loading state and the page Suspense fallback.role="status"loading announcement and hid decorative placeholders from assistive technology.MilestonesErrorBoundaryinstances around filters, actions, and the milestone list so one render failure does not remove healthy siblings.Try againresets only the failed subtree.MILESTONES_SECTION_FAILEDmetadata with a stable section label and React component stack for observability.docs/MILESTONES_RESILIENCE.mdwith the design contract, accessibility guidance, testing strategy, and maintenance checklist.Verification
npm run linton all changed source/test files: passed.git diff --check: passed.npm run lint,npm test -- --runInBand, andnpm run buildare currently blocked by pre-existing unrelated issues onmain, including merge-conflict markers and duplicate declarations in reputation/settings files, plus existing snapshot and dynamic-dialog failures. These are documented here so the baseline status is explicit.Closes #1105